Skip to content

dexed: Fix darwin build#521027

Merged
infinisil merged 1 commit into
NixOS:masterfrom
Linschlager:fix-darwin-dexed
May 17, 2026
Merged

dexed: Fix darwin build#521027
infinisil merged 1 commit into
NixOS:masterfrom
Linschlager:fix-darwin-dexed

Conversation

@Linschlager
Copy link
Copy Markdown
Contributor

@Linschlager Linschlager commented May 16, 2026

Opened a PR upstream to bump minimum macOS versions which resolves the build issues: asb2m10/dexed#523

#ZurichZHF

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@Linschlager
Copy link
Copy Markdown
Contributor Author

Linschlager commented May 16, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 521027
Commit: 4d6d3fcd256c9053ac4ca9a21fb2ea1a5d5735bf

aarch64-darwin

✅ 1 package built:
  • dexed

@nixpkgs-ci nixpkgs-ci Bot requested a review from OPNA2608 May 16, 2026 17:23
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 16, 2026
@ofborg ofborg Bot added the 6.topic: darwin Running or building packages on Darwin label May 17, 2026
das-g
das-g approved these changes May 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@das-g das-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 change LGTM, including change suggested to upstream in asb2m10/dexed@e41f1b8
👍 commit message LGTM

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 17, 2026
infinisil
infinisil requested changes May 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should link to the PR a patch comes from, otherwise lgtm!

Comment thread pkgs/by-name/de/dexed/package.nix
@infinisil infinisil enabled auto-merge May 17, 2026 15:03
@infinisil infinisil added this pull request to the merge queue May 17, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels May 17, 2026
Merged via the queue into NixOS:master with commit 879d308 May 17, 2026
29 checks passed
@OPNA2608 OPNA2608 mentioned this pull request May 17, 2026
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@infinisil infinisil infinisil approved these changes

@OPNA2608 OPNA2608 Awaiting requested review from OPNA2608

+1 more reviewer

@das-g das-g das-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Linschlager @das-g @infinisil @OPNA2608