Skip to content

hyprlandPlugins.hyprspace: unstable-2025-09-28 -> unstable-2026-05-28#518869

Merged
Atemu merged 1 commit into
NixOS:masterfrom
singhc7:hyprspace
May 29, 2026
Merged

hyprlandPlugins.hyprspace: unstable-2025-09-28 -> unstable-2026-05-28#518869
Atemu merged 1 commit into
NixOS:masterfrom
singhc7:hyprspace

Conversation

@singhc7
Copy link
Copy Markdown
Contributor

@singhc7 singhc7 commented May 10, 2026 •
edited
Loading

ZHF: #516381 (Part of)

Hydra Failure (Click the banner to go to Hydra build report):

hyprspace

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot requested a review from donovanglover May 10, 2026 22:33
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 10, 2026
@singhc7
Copy link
Copy Markdown
Contributor Author

singhc7 commented May 10, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 518869
Commit: 82fb3366a011d12452b360a7c7a9c8d6c3dcf2d4 (subsequent changes)
Merge: d7096bc3558638df84a8c52d9078e684953b6294

Logs: https://github.com/singhc7/nixpkgs-review-gha/actions/runs/25641572377

x86_64-linux

✅ 1 package built:
  • hyprlandPlugins.hyprspace

aarch64-linux

✅ 1 package built:
  • hyprlandPlugins.hyprspace

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@singhc7
Copy link
Copy Markdown
Contributor Author

singhc7 commented May 10, 2026

Could a maintainer apply the 0.kind: ZHF Fixes label? I don't have permissions for it. Thanks!

@yayayayaka yayayayaka added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 11, 2026
Atemu
Atemu requested changes May 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke again with 55.

@singhc7
Copy link
Copy Markdown
Contributor Author

singhc7 commented May 21, 2026

Yeah, 0.55 broke plugin API compat and upstream hasn't shipped a fix yet. Two open PRs attempting it: KZDKM/Hyprspace#230 (general 0.55 compat) and KZDKM/Hyprspace#231 (startup config reload crash, stacked on top of KZDKM/Hyprspace#230). Author of KZDKM/Hyprspace#231 says they'll rebase if KZDKM/Hyprspace#230 merges first, so KZDKM/Hyprspace#231 is effectively the superset.

Built both against current nixpkgs master, both compile clean. Going with #231 gets us both fixes in one patch.

Options:

  1. Carry Fix Hyprland 0.55 startup config reload crash KZDKM/Hyprspace#231 as a patch here, pinned to a specific commit (not the pull/N.patch URL since those move on force-push). Drop it once upstream merges either.
  2. Land the bump with meta.broken = true + tracking link, unbreak in a follow-up.
  3. Hold this PR until upstream lands a fix.

Leaning (1) given the patch is verified and covers both issues. Which do you want?

@mdaniels5757 mdaniels5757 added the backport release-26.05 Backport PR automatically label May 25, 2026
@singhc7
hyprlandPlugins.hyprspace: unstable-2025-09-28 -> unstable-2026-05-28
90a7638 
Picks up upstream commits including the fix for the `LayoutManager.hpp`
include path, which was breaking the build against the Hyprland version
currently in nixpkgs.

Fixes: https://hydra.nixos.org/build/327871454
@singhc7 singhc7 changed the title hyprlandPlugins.hyprspace: unstable-2025-09-28 -> unstable-2026-04-01 hyprlandPlugins.hyprspace: unstable-2025-09-28 -> unstable-2026-05-28 May 29, 2026
@singhc7
Copy link
Copy Markdown
Contributor Author

singhc7 commented May 29, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 518869
Commit: 90a7638678e0a660c8e1789d2be26394864f2201 (subsequent changes)
Merge: 49f1f6ab167dce1062494f97bc8248b0e14b81bf

Logs: https://github.com/singhc7/nixpkgs-review-gha/actions/runs/26611217473

x86_64-linux

✅ 1 package built:
  • hyprlandPlugins.hyprspace

aarch64-linux

✅ 1 package built:
  • hyprlandPlugins.hyprspace

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@singhc7
Copy link
Copy Markdown
Contributor Author

singhc7 commented May 29, 2026

@Atemu upstream has since shipped the 0.55 compat fixes, I've updated the bump to unstable-2026-05-28 which picks them up. Builds clean on my end, should be good to go now.

@singhc7 singhc7 requested a review from Atemu May 29, 2026 01:12
@Atemu Atemu added this pull request to the merge queue May 29, 2026
@Atemu
Copy link
Copy Markdown
Member

Atemu commented May 29, 2026

Thanks :)

Merged via the queue into NixOS:master with commit 4236004 May 29, 2026
28 checks passed
@nixpkgs-ci nixpkgs-ci Bot mentioned this pull request May 29, 2026
Open
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci Bot commented May 29, 2026

Successfully created backport PR for release-26.05:

@github-actions github-actions Bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 29, 2026
@singhc7 singhc7 deleted the hyprspace branch May 29, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Atemu Atemu Atemu approved these changes

@donovanglover donovanglover Awaiting requested review from donovanglover

Assignees

No one assigned

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 8.has: package (update) This PR updates a package to a newer version 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. backport release-26.05 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@singhc7 @Atemu @mdaniels5757 @yayayayaka