Skip to content

flac2mp3: init at 1.0.1#494902

Merged
Lassulus merged 1 commit intoNixOS:masterfrom
LilaHummel:flac2mp3
Feb 28, 2026
Merged

flac2mp3: init at 1.0.1#494902
Lassulus merged 1 commit intoNixOS:masterfrom
LilaHummel:flac2mp3

Conversation

@LilaHummel
Copy link
Copy Markdown
Contributor

@LilaHummel LilaHummel commented Feb 27, 2026

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 8.has: package (new) This PR adds a new package 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Feb 27, 2026
ambroisie
ambroisie reviewed Feb 27, 2026
View reviewed changes
ambroisie
ambroisie reviewed Feb 27, 2026
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Feb 27, 2026
@LilaHummel LilaHummel force-pushed the flac2mp3 branch 2 times, most recently from c30af7f to 0e1edf9 Compare February 27, 2026 23:59
ambroisie
ambroisie reviewed Feb 28, 2026
View reviewed changes
ambroisie
ambroisie reviewed Feb 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ambroisie ambroisie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to fix still, will be fine after that.

@LilaHummel
Copy link
Copy Markdown
Contributor Author

LilaHummel commented Feb 28, 2026 •
edited
Loading

Should be addressed. Thanks for the review.

ambroisie
ambroisie reviewed Feb 28, 2026
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 28, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Feb 28, 2026
@Lassulus Lassulus added this pull request to the merge queue Feb 28, 2026
Merged via the queue into NixOS:master with commit 8469d14 Feb 28, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambroisie ambroisie ambroisie approved these changes

+1 more reviewer

@riotbib riotbib riotbib approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LilaHummel @ambroisie @riotbib @Lassulus