Revert "python3Packages.mocket: 3.13.2 -> 3.13.4"#402824
Closed
booxter wants to merge 1 commit intoNixOS:stagingfrom
Closed
Revert "python3Packages.mocket: 3.13.2 -> 3.13.4"#402824booxter wants to merge 1 commit intoNixOS:stagingfrom
booxter wants to merge 1 commit intoNixOS:stagingfrom
Conversation
This was referenced Apr 29, 2025
github-actions
bot
added
6.topic: python
This reverts commit 9e99614. This bump broke the package on darwin. The new version didn't include any bug fixes or new features, just refactoring, so there's no regression in reverting it for now while we try to understand what broke in upstream. Related: NixOS#400373 Upstream bug: mindflayer/python-mocket#287 Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
booxter
force-pushed
the
revert-mocket-bump
branch
from
c0241ad to
4e8e331
Compare
Contributor
Author
|
We have both a short-term fix for Nix (disable the test) and the actual fix in upstream: mindflayer/python-mocket#289 Closing since revert would be counterproductive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 9e99614.
This bump broke the package on darwin. The new version didn't include
any bug fixes or new features, just refactoring, so there's no
regression in reverting it for now while we try to understand what broke
in upstream.
Related: #400373
Upstream bug: mindflayer/python-mocket#287
Signed-off-by: Ihar Hrachyshka ihar.hrachyshka@gmail.com
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.