zlib: use default configure script on windows

[getchoo]

Closes #366427

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[greg-hellings]

It now builds for me. Does the pkg-config file belong under bin?

greg@jude ~ @ ll result/bin/pkgconfig/
total 4
-r--r--r-- 2 root root 322 Dec 31  1969 zlib.pc

I believe that those still belong under lib/

@ find /nix/store -type d -name pkgconfig | grep mingw
/nix/store/0iyhgjknxxwr6nqw7xwqlzi79gngp2ic-zlib-x86_64-w64-mingw32-1.3.1-dev/lib/pkgconfig
/nix/store/5gc8pw7w7mkq5lqlfac0rqx6dymbvwm2-brotli-x86_64-w64-mingw32-1.1.0-dev/lib/pkgconfig
/nix/store/vnjkhgadl688a9liz286qs7z1rzyb68i-bzip2-x86_64-w64-mingw32-1.0.8-dev/lib/pkgconfig
/nix/store/xfygbm4qjc88dpx298c0ckxggzq1s04g-xz-x86_64-w64-mingw32-5.6.3-dev/lib/pkgconfig
/nix/store/gahg8vdv0m8kb7xqpiy3afwzrikwidfz-nghttp2-x86_64-w64-mingw32-1.64.0-dev/lib/pkgconfig
/nix/store/q88z2fqdryqpgcqyjj1damx26bqqi62s-pcre2-x86_64-w64-mingw32-10.44-dev/lib/pkgconfig
/nix/store/2f5s4pih0s0915cm5sv5ns4jmdvvqmzd-icu4c-x86_64-w64-mingw32-74.2-dev/lib/pkgconfig
/nix/store/qfnzx696najyi518119wxkgriv81qpfs-zstd-x86_64-w64-mingw32-1.5.6-dev/lib/pkgconfig
/nix/store/c94fja7dmkbvl1wisf8v08mfgjc4vmxl-libidn2-x86_64-w64-mingw32-2.3.7-dev/lib/pkgconfig
/nix/store/yc8mfw8kmqisclb5almdyg6ayh7dg15w-openssl-x86_64-w64-mingw32-3.3.2-dev/lib/pkgconfig
/nix/store/qds49amz4x9h92zcqgp68xnsiy8gzfiv-libssh2-x86_64-w64-mingw32-1.11.1-dev/lib/pkgconfig
/nix/store/lbljf9jbfbzdhmah067va6lk3a8ag0ma-curl-x86_64-w64-mingw32-8.11.0-dev/lib/pkgconfig
/nix/store/cmgc9kwhfdwbxbx97r5cggqnwdzn0vyn-sword-x86_64-w64-mingw32-1.9.0-dev/lib/pkgconfig
/nix/store/i08cmbkxf7z5zckyd9zzszfp77ycvndx-zlib-x86_64-w64-mingw32-1.3.1-dev/lib/pkgconfig
/nix/store/3p0l8cg0b749yjwwzrhg1wf1kv9l25pw-zlib-aarch64-w64-mingw32-1.3.1/bin/pkgconfig

[getchoo]

Doesn't seem like I can avoid a rebuild on other platforms, as patches will now be an empty list, dontConfigure is unset, etc.

[greg-hellings]

Doesn't seem like I can avoid a rebuild on other platforms, as patches will now be an empty list, dontConfigure is unset, etc.

Your changes only affect mingw targets, and the pkgsCross are not build as part of the testing. That means changes like this kinda rely on code reviewers instead of hydra to test the changes on the target environment. (This means that they don't block merges, but also that they are brittle and easily broken). I'm running a build locally of the cross target package. I'll update in a bit when that's done.

[greg-hellings]

FWIW, MSYS2 apply this rather large patch (among others): msys2/MINGW-packages@28541f5/mingw-w64-zlib/01-zlib-1.2.11-1-buildsys.mingw.patch.

That does seem a more robust way of handling it. Any reason to not try that one out, @getchoo ?

[greg-hellings]

Can we please get this merged?

[greg-hellings]

FWIW, MSYS2 apply this rather large patch (among others): msys2/MINGW-packages@28541f5/mingw-w64-zlib/01-zlib-1.2.11-1-buildsys.mingw.patch.

Looking further into this, I don't think their patch is applicable directly to our usage here. In their patch they force all MinGW targets to build both shared and static libraries every time. That's pretty common in MinGW distributions I've used, but it's not how nixpkgs is setup to roll. So I don't think that we should go with their patch set. The one in this PR already works great.

[getchoo]

That does seem a more robust way of handling it. Any reason to not try that one out, @getchoo ?

Nope, this just slipped my inbox!

I am a little hesitant to add this though, as I'm not completely sure why they're making some of these changes (as I'd hope upstream would do most of the heavy lifting here) and like you said, I'm not sure they're super applicable here

If any issues come up from the one I have, I will gladly move to this instead

[SuperSandro2000]

LGTM but I am a Windows cross noob

[greg-hellings]

Now that the issue with the aarch64 cross compiler is addressed, this build failure is now directly halting other progress on ucrtAarch64 cross package builds. Any chance we can get it merged?

[greg-hellings]

It's been 5 more weeks. Please merge this? It's completely rendering the whole Windows on Arm cross compile target useless.

[RossSmyth]

Builds for me, looks good.

[greg-hellings]

Merge conflict resolution in #428871. @getchoo If you want to grab that version and push over top of this, you're welcome to do so. It's just a formatting change in the resolution.