cargo-show-asm tests: Mark add as inline(never)#282351
Merged
1 commit merged intoJan 20, 2024
Merged
Conversation
NixOSInfra
added
the
12.first-time contribution
ofborg
Bot
added
10.rebuild-darwin: 0
|
@ofborg build cargo-show-asm.passthru.tests |
|
@pacak the commit needs to confirm to the commit convention. eg: |
newer rustc automagically marks simple functions as inline, this includes `add` used for tests. Marking it as `inline(never)` makes sure it's always included so tests can find it
Contributor
Author
|
Changed it a bit. |
ghost
requested review from
matthiasbeyer
approved these changes
Jan 20, 2024
Contributor
|
Result of |
Contributor
|
Hm, |
delroth
added
the
12.approvals: 1
that is expected as the change was just in the test and wouldn't trigger a rebuild. |
Contributor
|
ah 🤠 sure... |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Newer version of rustc breaks currently included test, this PR should fix it.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)I didn't test it, but I made a similar change in cargo-show-asm repo here: pacak/cargo-show-asm#231
This should fix the failing test that shows up here: #281810
Add a 👍 reaction to pull requests you find important.