Skip to content

Nominate @trofi#106

Closed
vcunat wants to merge 1 commit intoNixOS:mainfrom
vcunat:nominate-trofi
Closed

Nominate @trofi#106
vcunat wants to merge 1 commit intoNixOS:mainfrom
vcunat:nominate-trofi

Conversation

@vcunat
Copy link
Copy Markdown
Member

@vcunat vcunat commented Apr 9, 2026

Motivation: huge amount of contributions; it's just too much work (for me) to keep merging them 😉
https://github.com/NixOS/nixpkgs/pulls?q=author%3Atrofi+is%3Amerged

Motivation: huge amount of contributions;
it's just too much work (for me) to keep merging them ;-)
https://github.com/NixOS/nixpkgs/pulls?q=author%3Atrofi+is%3Amerged
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Apr 9, 2026

Yes, please!

@vcunat
Copy link
Copy Markdown
Member Author

vcunat commented Apr 9, 2026

I'm not sure if @trofi was pinged, so doing it now. I haven't asked whether they want the access.

Copy link
Copy Markdown

@marcin-serwin marcin-serwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, they have rejected the previous nomination: #60 (comment)

@vcunat
Copy link
Copy Markdown
Member Author

vcunat commented Apr 9, 2026

Oh right, I didn't search well enough to find that. Though maybe the situation has changed. There certainly seem to be lots of PRs from @trofi currently.

@trofi
Copy link
Copy Markdown

trofi commented Apr 10, 2026

Thank you all for the nomination and the support! It means a lot to me.

Still, I have to decline.

I don't really do any substantial changes in nixpkgs and I lost track of many major nixpkgs changes over the past few years. I barely have time to do trivial bumps and fix a small build failure here and there. I certainly don't qualify to review and merge others' PRs.

@philiptaron
Copy link
Copy Markdown
Contributor

Trofi, your standards put my own to shame. I love merging your PRs and appreciate deeply your commitment to quality over time, demonstrated with thoughtful PRs and blameless but actionable feedback. These little things are substantial, in my book! I hope you hear the voice from those who love seeing your name as the author above and take it to heart, even if you continue to decline the nominations.

@emilazy
Copy link
Copy Markdown
Member

emilazy commented Apr 18, 2026

We’d be very happy to have @trofi on board, but of course respect his wishes and can’t onboard anyone who doesn’t want to be a committer. If that ever changes, we’ll be glad to see another nomination PR.

@emilazy emilazy closed this Apr 18, 2026
@vcunat
Copy link
Copy Markdown
Member Author

vcunat commented Apr 18, 2026

I'm a bit sad, as we have problems merging the influx of PRs, so I'd hope that such high-quality contributors could help a bit – at least by merging their own PRs in case it's nothing controversial and noone reacts for a long time.

I'm quite surprised from the amount of reactions, also considering other nomination PRs. A sign that @trofi is well known and liked in the community, I expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.