libstore: always use the socket if it exists #14773
Open
+32
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the behaviour of Nix to always communicate with the daemon, even if the store is writable to that user. Bypassing the daemon had a number of issues. Mainly, the client behaviour is not always consistent between users leading to confusion. The max-jobs counter is not shared between various instances of the Nix client. The clients fight between each-other to hold the lock on the sqlite database. By making the access consistent, it opens the road for the daemon to permanently hold the lock on the sqlite database, and get rid of the \"sqlite is busy\" type of errors.
github-actions
bot
added
documentation
store
Member
But this PR doesn't fix any of those issues. Forcing the use of the daemon just adds unnecessary overhead when (for instance) you're running Nix builds as root in a container. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This change modifies the behaviour of Nix to always communicate with the
daemon, even if the store is writable to that user.
Bypassing the daemon had a number of issues. Mainly, the client
behaviour is not always consistent between users leading to confusion.
The max-jobs counter is not shared between various instances of the Nix
client. The clients fight between each-other to hold the lock on the
sqlite database.
By making the access consistent, it opens the road for the daemon to
permanently hold the lock on the sqlite database, and get rid of the
"sqlite is busy" type of errors.
Reviving this after 5 years. See #4263
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.