libstore/aws-creds: Shut logs by default #14771
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xokdvium
added
the
backport 2.33-maintenance
Ericson2314
approved these changes
Dec 10, 2025
xokdvium
removed
the
backport 2.33-maintenance
Contributor
Author
|
Needs a bit more work. Ideally we wouldn't be redirecting to stderr and use our logging infra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
By default the sdk is very chatty and barf unwanted messages if e.g.
.aws/config doesn't exist and such. Shut it since it would spam messages
if you only set up creds via the environment. That is poor UX and the sdk provides a very bad default.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.