C API: Add copy_path to Store API #14768
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This provides more granular control over paths as they are copied in a few ways:
Context
I'm not certain this is an API that should be exposed given the existing
nix_store_copy_closure, but putting up a PR for feedback anyways. My primary motivation is to be able to monitor copy progress on a per-path basis. AFAIK the alternative way to do this is to log & parse the JSON format--not possible from FFI (?). I'm also using this to work around #14604 and #14569 by just orchestrating the copy over FFI, which works pretty well.Tested on my fork calling from Rust.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.