-
Notifications
You must be signed in to change notification settings - Fork 40
[ANDROID][AGENTS] Fix example app build #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
void-memories
wants to merge
12
commits into
NimbleEdge:main
Choose a base branch
from
void-memories:naman/format-kotlin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8f31286
format code
void-memories 05ecfa4
make agents pick nimblenet locally
void-memories b6e633b
remove version hardcoding
void-memories 3d56a2c
implement offline init for notification_summarizer
void-memories dc64510
Merge remote-tracking branch 'upstream/main' into naman/format-kotlin
void-memories da0afdc
change dep visibility
void-memories a534ae1
remove nimblenet libs version hardcoding
void-memories 6551b0c
add router activity
void-memories eff4f09
add EOF newline
void-memories 2ce092e
Cosmetics
jpuneet 9b9d334
Update agents/examples/android/README.md
void-memories eb8c8dc
Update agents/examples/android/README.md
void-memories File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,4 +4,5 @@ | |
| third_party/runtime/ | ||
| !third_party/runtime/CMakeLists.txt | ||
| __pycache__/ | ||
| .pytest_cache/ | ||
| .pytest_cache/ | ||
| .venv | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,16 +10,36 @@ Example Android app demonstrating the Notifications Summarizer Agent integration | |
|
|
||
| ## Setup | ||
|
|
||
| 1. **Add Credentials in Code** | ||
| Open `app/src/main/java/dev/deliteai/examples/App.kt` and replace the placeholder values in the `NimbleNetConfig` block (`YOUR_CLIENT_ID`, `YOUR_HOST`, `YOUR_CLIENT_SECRET`) with your own credentials. | ||
| 1. **Run the following commands** | ||
|
|
||
| 2. **Open in Android Studio** | ||
| **Change to repo root** | ||
| ```bash | ||
| cd deliteAI/agents/examples/android | ||
| cd "$(git rev-parse --show-toplevel)" | ||
| ``` | ||
|
|
||
| 2. **Download Llama ONNX assets** | ||
| ```bash | ||
| python3 coreruntime/tests/utils/download_from_s3.py \ | ||
| --default_bucket deliteai \ | ||
| --prefix build-dependencies/llama-3.2-1B/onnx \ | ||
| --output agents/examples/android/app/src/main/assets/llama-3 \ | ||
| --archive_output True | ||
| ``` | ||
|
|
||
| 3. **Generate Python AST and move it into your Android assets** | ||
| ```bash | ||
| coreruntime/scripts/gen_python_ast.py \ | ||
| agents/notifications_summarizer/delitepyAssets/main.py \ | ||
| && mv "${_%.py}.ast" agents/examples/android/app/src/main/assets/ | ||
| ``` | ||
|
|
||
| 4. **Open in Android Studio** | ||
| ```bash | ||
| cd agents/examples/android | ||
| ``` | ||
| Open this directory in Android Studio. | ||
|
|
||
| 3. **Sync and Build** | ||
| 5. **Sync and Build** | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the trailing space in this line intentional?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If yes, you can replace the trailing |
||
| Let Gradle sync, then build the project. | ||
|
|
||
| ## Running the App | ||
|
|
@@ -54,4 +74,4 @@ App-Wise Summary: | |
| com.whatsapp | ||
| Meeting reminder message. | ||
| Group chat has 2 new messages. | ||
| ``` | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO,
$_here may make it difficult for the reader to understand what's going on.