Repository navigation
Storybook: opens in modern, with a branded Welcome page - #31
Merged
Merged
Conversation
- People browsing the workshop start in the modern theme, as rowkit.dev does. The browser tests and their a11y gate still start in Windows 98 (Vite mode `test`), and VITE_RK_THEME picks either explicitly. - visual:check names the theme in the URL (Windows 98 unless --theme modern), so the pixel baseline does not follow the workshop's default. - A Welcome page first in the sidebar: the logo, one line on what rowkit is, how to use Theme, Scheme, Accessibility and Interactions, and links to the docs, GitHub and npm. Built from rowkit's components, so it reads in every theme; the logo takes its light letters on a dark scheme. - The docs pages take the chrome's light or dark brand theme. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test);VITE_RK_THEMEpicks either, sotest:a11y:modernis unchanged.--theme modern), so the pixel baseline does not move with the workshop default.No package changes, no changeset. Checked: lint, typecheck,
test:a11yandtest:a11y:modern(210/210 each), visual:check in both themes, the Welcome page in Windows 98, modern light and modern dark.🤖 Generated with Claude Code