bug/major: ios/safari: fix issue with newer iOS release and webkit#53
Open
NicolasCARPi wants to merge 1 commit into
Open
bug/major: ios/safari: fix issue with newer iOS release and webkit#53NicolasCARPi wants to merge 1 commit into
NicolasCARPi wants to merge 1 commit into
Conversation
Recent WebKit/iOS Safari releases can hand Dropzone dropped File objects whose backing data becomes unavailable shortly after the drop event. In that state the drop is detected correctly, but the upload can send an empty body. For plain file drops on Safari/iOS, eagerly read each dropped File with FileReader.readAsArrayBuffer() and rebuild a fresh File from the bytes before passing it to the existing handleFiles flow. This keeps the upload independent of the original transient file handle. Keep directory drops on the existing DataTransferItem/webkitGetAsEntry path so folder traversal behavior is unchanged, and fall back to the original File if rehydration is unavailable or fails. References: - https://developer.mozilla.org/en-US/docs/Web/API/FileReader/readAsArrayBuffer - https://developer.mozilla.org/en-US/docs/Web/API/File - https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer/files - https://developer.mozilla.org/en-US/docs/Web/API/DataTransferItem/webkitGetAsEntry fix #52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent WebKit/iOS Safari releases can hand Dropzone dropped File objects whose backing data becomes unavailable shortly after the drop event. In that state the drop is detected correctly, but the upload can send an empty body.
For plain file drops on Safari/iOS, eagerly read each dropped File with FileReader.readAsArrayBuffer() and rebuild a fresh File from the bytes before passing it to the existing handleFiles flow. This keeps the upload independent of the original transient file handle.
Keep directory drops on the existing DataTransferItem/webkitGetAsEntry path so folder traversal behavior is unchanged, and fall back to the original File if rehydration is unavailable or fails.
References:
fix #52
Make sure to run the test suite.