Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assign SA Algorithm Integration
Description
Implemented and integrated the algorithm that assigns students to Student Accelerators (SAs) based on group load balancing. This functionality is now available via the endpoint:
PUT /api/accelerate/students/assign-sa/{student_id}
Issues Fixed
No direct issue
Tests
Tested locally using pytest. All tests passed successfully, including:
7 successful assignment cases
2 failure scenarios (e.g., no SA available, database error handling) - FIXED
Notes
Unable to test on Heroku due to two-factor authentication access restrictions.
Modified the Student model to change the ethnicities relationship loading strategy from lazy="joined" to lazy="select" to prevent unwanted eager loading of missing fields in the database.
Checklist
I've reviewed the contribution guide
I've confirmed the changes work on my machine
This pull request is ready for review