[repo-assist] test: add coverage-gap tests for Frac, Pow, Divide, and Clamp - #224
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
- Frac: 5 tests (fractional parts for positive, negative, integer, zero; and parity check against FractionalPart) - Pow: negative-exponent guard (ArgumentOutOfRangeException) and zero-exponent returns One - Divide(long): zero-divisor guard (DivideByZeroException) - Clamp: min-exceeds-max guard (ArgumentException) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Adds 9 new tests in a new
FixedPointNanoCoverageGapTestsfixture that cover four behaviours which had no direct test coverage:FracFractionalPartPownegative exponentArgumentOutOfRangeException; zero exponent returnsOneDivide(FixedPointNano, long)zero divisorDivideByZeroExceptionClampmin > maxArgumentExceptionWhy these gaps?
Fracis a public static method whose implementation is identical toFractionalPart, but it had no test of its own. It could silently diverge in future without any test catching it.Pow(-1)guard branch existed in the source but was never exercised by the existingPowMatchesDecimalReferencecases (all used non-negative exponents).Divide(long, 0L)— theintoverload zero-divisor path was tested; thelongoverload was not, even though it is a separate code path.Clamp(min > max)— theArgumentExceptionguard was present but untested.Test Status
All 1435 tests pass (9 added, 1426 pre-existing).
Add this agentic workflows to your repo
To install this agentic workflow, run