[repo-assist] perf: add [AggressiveInlining] to operator * - #223
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[repo-assist] perf: add [AggressiveInlining] to operator *#223github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
operator * is called in hot-path code (Lerp, Pow, consumer loops). Marking it [AggressiveInlining] allows the JIT to inline the Int128-multiply + bankers-round sequence at call sites, reducing call overhead for tight calculation loops. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Adds
[MethodImpl(MethodImplOptions.AggressiveInlining)]tooperator *.Rationale
operator *is invoked on every multiply and is used insideLerp,Pow, and consumer calculation loops. Every other arithmetic operator (+,-, unary-,/,%,++,--) already carries[AggressiveInlining];*was the only one missing the annotation.By hinting the JIT to inline the
Int128-multiply + banker's-round sequence at call sites, we eliminate the call overhead for tight loops that repeatedly multiplyFixedPointNanovalues. The existingMultiplyRawbenchmark exercises this path.Changes
src/FixedPointNano/FixedPointNano.cs— one line added tooperator *Test Status
✅
dotnet build— succeeded, 0 warnings✅
dotnet test— 1426/1426 passedAdd this agentic workflows to your repo
To install this agentic workflow, run