Skip to content

fix: keep tracked ignored sources current in the watcher - #21

Open
503133214 wants to merge 1 commit into
NianJiuZst:mainfrom
503133214:fix/watch-tracked-ignored-files
Open

503133214 wants to merge 1 commit into
NianJiuZst:mainfrom
503133214:fix/watch-tracked-ignored-files

Conversation

@503133214

@503133214 503133214 commented Nov 5, 2026 •

Copy link
Copy Markdown

Files force-added to Git under an ignored directory are included by full indexing, but their edit/delete events were filtered out by the watcher. Newly tracked ignored files were also missed by path-driven sync until a periodic full scan.

Use the published snapshot to admit events for indexed ignored sources and removed parent directories. Rescan inventory on .git/index and .git/info/exclude changes, refresh the filter after publication/compaction, and let explicit path sync discover newly tracked ignored files. Explicit excludes and built-in dependency/build skips still apply. No engine or segment-format change is needed.

Validation

  • Filter and newly-tracked path regressions failed on faf5dea before the fix.
  • Four new tests cover positive/negative filtering, edit/add/delete, Git add/untrack, local exclude changes, and a real watcher receiving consecutive edits. Incremental snapshots are compared with fresh builds against the same Git inventory.
  • Workspace: 398 passed, 1 existing ignored, with 6 × 100 random edit steps. On this glibc host the unchanged vendored small_stack_reports_its_own_bounds test failed once (a requested 1 MiB stack reported ~2 MiB), then passed in isolation; the complete successful run used GLIBC_TUNABLES=glibc.pthread.stack_cache_size=0.
  • CI package-format check, strict all-target workspace Clippy excluding the vendored kernel, and git diff --check: passed.
  • Locked fastrel CLI build and existing CLI/MCP/prompt-hook/SQLite smoke: passed on WSL2 Linux, Rust 1.99.1.

Scope: metadata events are for repositories with an in-root .git/ directory. Linked-worktree metadata outside the watched root still relies on the existing periodic scan.

Hosted CI: run 42085352316 is action_required, awaiting approval of this fork's workflow run; the local validation above is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant