Repository navigation
Open teacher profiles with birth year, classes and login details - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teacher names in the management directory were static text, so users could not see an aggregated profile or distinguish contact email from the linked teacher login. Names now open a responsive profile dialog with teaching classes/subjects and homeroom classes for the selected academic year, contact details, status, optional birth year, and the actual linked login email from the existing owner-scoped access RPC.
Birth years can be entered or cleared, validate against 1900–the current year, and persist with global teacher profiles across years/devices. Account lookups distinguish loading, unlinked, and failed states; stale teacher/account responses are discarded. Opening account management from a profile selects that teacher and preserves the selection on retry.
Supabase cannot return existing passwords. The profile explains this and links to manual password management in Supabase; no password input, plaintext storage, default credential, or automatic reset email is introduced. No backend migration or teacher-website deployment change is needed.
Validation: focused teacher-details browser suite passes at desktop/mobile widths, covering aggregated classes, real/missing birth years, validation/save/clear/reload/cross-device sync, assignment-edit preservation, contact vs login email, safe password guidance, retry, management preselection, and late responses across teacher/account changes. Complete cloud-sync and teacher-portal suites pass. Screenshots inspected; syntax and whitespace checks pass.