Refactor notification scheduling with NotificationScheduleClock

[subsub97]

This pull request introduces a new NotificationScheduleClock component to centralize and standardize time-related logic for scheduling notifications, ensuring consistent timezone handling and future schedule checks. The changes also improve code readability and testability by refactoring direct time calculations into reusable methods. Additionally, the pull request includes tests for the new clock component and some minor code cleanups.

Core improvements to scheduling and time handling:

• Introduced the NotificationScheduleClock component to encapsulate current time retrieval (using the "Asia/Seoul" timezone) and provide a reusable isFutureSchedule method for checking if a schedule is in the future.
• Refactored NotificationSyncService to use NotificationScheduleClock for all time-related logic, replacing direct calls to LocalDateTime.now and manual timezone handling. [1] [2] [3] [4]

Normalization and code cleanup:

• Centralized time normalization logic in WorkScheduleTime.normalize, replacing inline LocalTime.of(hour, minute) usages with a dedicated method for clarity and consistency. [1] [2] [3]
• Simplified filtering logic for pending work notifications by using a predefined workNotificationTypes list.

Testing:

• Added a new test class NotificationScheduleClockTest to verify correct behavior of the clock component, including timezone handling and future schedule determination.

[github-actions]

Test Results

73 tests   73 ✅  1s ⏱️
11 suites   0 💤
11 files     0 ❌

Results for commit fd72e75.

[Copilot]

Pull request overview

This PR centralizes notification scheduling time logic by introducing a NotificationScheduleClock component (fixed to the Asia/Seoul timezone) and refactors notification sync logic to use it, improving consistency and testability of “future schedule” checks.

Changes:

• Added NotificationScheduleClock with now() and isFutureSchedule(...) helpers.
• Refactored NotificationSyncService to use the new clock and to centralize minute-level time normalization via WorkScheduleTime.normalize.
• Added NotificationScheduleClockTest to validate timezone-based now() behavior and future schedule comparisons.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/main/kotlin/com/moa/service/notification/NotificationScheduleClock.kt	New clock component for consistent Asia/Seoul time retrieval and future schedule checks.
src/main/kotlin/com/moa/service/notification/NotificationSyncService.kt	Refactors scheduling logic to use the clock + normalized times and simplifies work-notification filtering.
src/main/kotlin/com/moa/entity/notification/WorkScheduleTime.kt	Centralizes time normalization to minute precision.
src/test/kotlin/com/moa/service/notification/NotificationScheduleClockTest.kt	Adds unit tests covering timezone now() and future-schedule edge cases.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.