移行の領域の試験を決めた置き場所へ移す

tests/Carina.Api.Tests/FeatureTest/MigrationRecordEndpointTests.cs → tests/Carina.Api.Tests/Feature/Migration/GetMigrationRecordActionTests.cs

@@ -3,9 +3,10 @@
 
 using Carina.Domain.Migration;
 
-namespace Carina.Api.Tests.FeatureTest;
+namespace Carina.Api.Tests.Feature.Migration;
 
-public sealed class MigrationRecordEndpointTests
+[Trait("Category", "Feature")]
+public sealed class GetMigrationRecordActionTests
 {
     private const string Record = "/api/migration/record";
 

tests/Carina.Api.Tests/FeatureTest/MigrationFeature.cs → tests/Carina.Api.Tests/Feature/Migration/MigrationFeature.cs

@@ -2,6 +2,7 @@
 using System.Net.Http.Headers;
 using System.Text.Json;
 
+using Carina.Api.Tests.FeatureTest;
 using Carina.Domain.Base;
 using Carina.Domain.Encodings;
 using Carina.Domain.Migration;
@@ -12,7 +13,7 @@
 using Microsoft.Extensions.DependencyInjection.Extensions;
 using Microsoft.Extensions.Hosting;
 
-namespace Carina.Api.Tests.FeatureTest;
+namespace Carina.Api.Tests.Feature.Migration;
 
 internal sealed class HeldMigrationRecord : IMigrationRecordRepository
 {

tests/Carina.Api.Tests/FeatureTest/RoutedSurfaceTests.cs

@@ -17,6 +17,8 @@ public sealed class RoutedSurfaceTests(TestingWebApplicationFactory factory)
 {
     private const int TheSurfacesThisRepositoryHadWhenTheSweepWasWritten = 50;
 
+    private const string MigrationRoot = "/api/migration";
+
     [Fact]
     public void EveryRoutedSurfaceSaysWhetherItDestroys()
     {
@@ -421,6 +423,51 @@ public void AskingForTheLedgerToBeCheckedDiscardsNothing()
                 .Effect);
     }
 
+    [Fact]
+    public void TheMigrationSurfaceIsTheOneTheRecordIsReadThrough()
+        => Assert.Equal(
+            ["GET /api/migration/record"],
+            MigrationSurfaces().Select(surface => surface.ToString()).Order(StringComparer.Ordinal).ToArray());
+
+    [Fact]
+    public void NothingAnywhereElseOffersAMigrationOfItsOwn()
+        => Assert.Equal(
+            ["/api/migration/record"],
+            Inventory()
+                .Select(surface => surface.Pattern)
+                .Where(pattern => pattern.Contains("migration", StringComparison.OrdinalIgnoreCase))
+                .Distinct(StringComparer.Ordinal)
+                .Order(StringComparer.Ordinal)
+                .ToArray());
+
+    [Fact]
+    public void NothingUnderTheMigrationSurfaceIsAskedForOnAMethodThatWrites()
+        => Assert.All(MigrationSurfaces(), surface => Assert.True(
+            HttpMethods.IsGet(surface.Method),
+            $"{surface} reaches the record on a method that is not a read"));
+
+    [Fact]
+    public void NothingUnderTheMigrationSurfaceChangesAnythingOrSaysItDestroys()
+        => Assert.All(MigrationSurfaces(), surface => Assert.Equal(EndpointEffect.Reading, surface.Effect));
+
+    [Fact]
+    public void NothingUnderTheMigrationSurfaceDeletes()
+        => Assert.Empty(EndpointRules.SurfacesThatDeleteUnder(Inventory(), MigrationRoot));
+
+    [Fact]
+    public void TheRootIsReadAsAWholeSegmentAndNotAsLeadingLetters()
+    {
+        RoutedSurface[] inventory =
+        [
+            new("POST", "/api/migrations-of-a-kind/run", EndpointEffect.Changing),
+            new("POST", "/api/migration/run", EndpointEffect.Changing),
+        ];
+
+        Assert.Equal(
+            ["POST /api/migration/run"],
+            inventory.Where(UnderTheMigrationRoot).Select(surface => surface.ToString()).ToArray());
+    }
+
     [Fact]
     public void TheInventoryHoldsTheSurfacesTheDocumentCannotDescribe()
     {
@@ -511,5 +558,11 @@ public async Task APathThatMerelyLooksLikeAnEnumeratedSurfaceIsRefused(string pa
         Assert.Equal(HttpStatusCode.Unauthorized, response.StatusCode);
     }
 
+    private static bool UnderTheMigrationRoot(RoutedSurface surface)
+        => string.Equals(surface.Pattern, MigrationRoot, StringComparison.Ordinal)
+           || surface.Pattern.StartsWith(MigrationRoot + "/", StringComparison.Ordinal);
+
+    private IEnumerable<RoutedSurface> MigrationSurfaces() => Inventory().Where(UnderTheMigrationRoot);
+
     private IReadOnlyList<RoutedSurface> Inventory() => RouteInventory.Of(factory);
 }

tests/Carina.Conventions.Tests/TestLayoutRules.cs

@@ -32,7 +32,6 @@ public static class TestLayoutRules
         "Integrity",
         "Live",
         "Machines",
-        "Migration",
         "Net",
         "Persistence",
         "Playback",
@@ -66,6 +65,8 @@ public static class TestLayoutRules
         new("Epg", "src/Carina.Api/Events/ProgrammeFeedReaders.cs"),
         new("Epg", "src/Carina.Api/Events/ProgrammeFeedStream.cs"),
         new("Logos", "src/Carina.Api/Logos/LogoDelivery.cs"),
+        new("Migration", "src/Carina.Db/CarryArguments.cs"),
+        new("Migration", "src/Carina.Db/CarrySaid.cs"),
         new("Notifications", "src/Carina.Api/Requests/NotificationRequests.cs"),
         new("Notifications", "src/Carina.Api/Services/NotificationDestinationService.cs"),
         new("Notifications", "src/Carina.Api/Services/NotificationPushService.cs"),
@@ -111,6 +112,7 @@ public static class TestLayoutRules
         new("Channels", "LogoVisitSchema"),
         new("Channels", "ServiceReachSchema"),
         new("Channels", "StationLogoSchema"),
+        new("Migration", "MigrationRecordSchema"),
         new("Programmes", "ProgrammeSearchFoldingSchema"),
         new("Quality", "QualityTablesDroppedWholeSchema"),
         new("Recordings", "RecordingBroadcastGroupSchema"),

tests/Carina.Db.Tests/MigrationRecordSchemaTests.cs → tests/Carina.Db.Tests/DbIntegration/Infra/Migration/MigrationRecordSchemaTests.cs

@@ -1,8 +1,10 @@
 using Carina.Domain.Migration;
+using Carina.Infrastructure.Migration;
+using Carina.Infrastructure.Persistence;
 
 using Npgsql;
 
-namespace Carina.Db.Tests;
+namespace Carina.Db.Tests.DbIntegration.Infra.Migration;
 
 [Collection(ConnectionEnvironmentCollection.Name)]
 [Trait("Category", "DbIntegration")]
@@ -13,6 +15,8 @@ public sealed class MigrationRecordSchemaTests(MigratedScratchDatabase database)
 
     private const string Ended = "timestamptz '2026-09-08 03:04:00+00'";
 
+    private static readonly CancellationToken Cancel = CancellationToken.None;
+
     public static TheoryData<string> Refusals => Named(MigrationRefusals.All.Select(refusal => refusal.ToString()));
 
     public static TheoryData<string> Counted =>
@@ -337,6 +341,37 @@ await CountAsync(
                 $"SELECT count(*) FROM migration_rule_proposal WHERE run_id = '{run}' AND rule_id IS NULL"));
     }
 
+    [Fact]
+    public async Task ASecondRunIsRefusedWhileTheFirstStillHoldsTheLease()
+    {
+        await using CarinaDbContext first = CarinaDbContextFactory.Create(database.ConnectionString);
+        await using CarinaDbContext second = CarinaDbContextFactory.Create(database.ConnectionString);
+
+        IAsyncDisposable? held = await new MigrationLease(first).TakeAsync(Cancel);
+
+        Assert.NotNull(held);
+        Assert.Null(await new MigrationLease(second).TakeAsync(Cancel));
+
+        await held.DisposeAsync();
+    }
+
+    [Fact]
+    public async Task TheNextRunGetsTheLeaseOnceTheFirstHasGivenItBack()
+    {
+        await using CarinaDbContext first = CarinaDbContextFactory.Create(database.ConnectionString);
+        await using CarinaDbContext second = CarinaDbContextFactory.Create(database.ConnectionString);
+
+        IAsyncDisposable? held = await new MigrationLease(first).TakeAsync(Cancel);
+        Assert.NotNull(held);
+        await held.DisposeAsync();
+
+        IAsyncDisposable? next = await new MigrationLease(second).TakeAsync(Cancel);
+
+        Assert.NotNull(next);
+
+        await next.DisposeAsync();
+    }
+
     private static TheoryData<string> Named(IEnumerable<string> names)
     {
         TheoryData<string> data = [];

tests/Carina.Db.Tests/CarryArgumentsTests.cs → tests/Carina.Db.Tests/Unit/Infra/Migration/CarryArgumentsTests.cs

@@ -1,7 +1,8 @@
 using Carina.Domain.Migration;
 
-namespace Carina.Db.Tests;
+namespace Carina.Db.Tests.Unit.Infra.Migration;
 
+[Trait("Category", "Unit")]
 public sealed class CarryArgumentsTests
 {
     [Fact]

tests/Carina.Db.Tests/CarrySaidTests.cs → tests/Carina.Db.Tests/Unit/Infra/Migration/CarrySaidTests.cs

@@ -2,8 +2,9 @@
 using Carina.Domain.Encodings;
 using Carina.Domain.Migration;
 
-namespace Carina.Db.Tests;
+namespace Carina.Db.Tests.Unit.Infra.Migration;
 
+[Trait("Category", "Unit")]
 public sealed class CarrySaidTests
 {
     private static readonly DateTime Began = new(2026, 9, 8, 3, 0, 0, DateTimeKind.Utc);