Merged
Conversation
The /dandi/get-recommended-species endpoint failed because dandischema's data files (spdx_license_ids.json) were not collected by PyInstaller. Add dandischema to modules_to_collect so its resources are bundled. Also add res.ok checks to fetch handlers in globals.ts so that HTTP error responses are properly rejected instead of being parsed as JSON and stored as non-array values, which caused getSpeciesInfo to crash. Fixes #1071 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
The windows and mac apps now work with this fix. My plan is to re-tag and re-release |
bendichter
approved these changes
Mar 8, 2026
Collaborator
|
@rly sounds good. It looks to me like 1.10 was never released in the first place |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dandischematomodules_to_collectin the PyInstaller spec so its data files (e.g.,spdx_license_ids.json) are bundled. This was causing the/dandi/get-recommended-speciesendpoint to fail with aFileNotFoundErrorin the packaged app.res.okchecks to fetch handlers inglobals.tsso that HTTP 500 responses are properly rejected instead of being parsed as JSON and passed togetSpeciesInfo, which crashes on non-array input.Resolves #1071
Test plan
/dandi/get-recommended-speciesreturns species data🤖 Generated with Claude Code