Rename SKIP_PYNWB var and update CI/tests to skip PyNWB dependent tests on older MATLAB releases#791
Open
ehennestad wants to merge 3 commits intomainfrom
Open
Rename SKIP_PYNWB var and update CI/tests to skip PyNWB dependent tests on older MATLAB releases#791ehennestad wants to merge 3 commits intomainfrom
ehennestad wants to merge 3 commits intomainfrom
Conversation
Replace the old SKIP_PYNWB_COMPATIBILITY_TEST_FOR_TUTORIALS env var with SKIP_PYNWB_TESTS across tests and nwbtest.m, and update +tests/nwbtest.default.env.
Update CI workflow matrix keys and usage in prepare_release.yml, run_tests.yml, and configurations/matlab_release_matrix_strategy.yml to use the new key (matrix.skip-pynwb-tests) and wire the MATLAB setenv accordingly.
Move conditional installation of pynwb into the workflows (install pynwb only when skip-pynwb-tests == '0') and remove the direct git+ dependency from +tests/requirements.txt (update comment to reflect conditional installs).
Also add TestTags = {'UsesPython'} to PyNWBIOTest.
These changes centralize the CI control of pynwb installation and standardize the skip variable name.
3 tasks
checking if this class attribute trips up docs build
Move TestTags to methods blocks. Check if that fixes issue with sphinx build of docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MATLAB R2022b and earlier only supports Python <= 3.9, whereas pynwb/nwbinspector supports Python >= 3.10.
This makes it difficult to test Pynwb-dependent tests on older MATLAB releases, and this PR makes the PyNWB-dependent tests fully conditional.
SKIP_PYNWB_COMPATIBILITY_TEST_FOR_TUTORIALSenv var withSKIP_PYNWB_TESTSacross tests and nwbtest.mChecklist
fix #XXwhereXXis the issue number?