various minor build and bug fixes and some updates#21
Open
rudimeier wants to merge 15 commits intoNeuroanatomyAndConnectivity:masterfrom
Open
various minor build and bug fixes and some updates#21rudimeier wants to merge 15 commits intoNeuroanatomyAndConnectivity:masterfrom
rudimeier wants to merge 15 commits intoNeuroanatomyAndConnectivity:masterfrom
Conversation
Seems that we don't need it. Removing them solves trouble when building on OSX.
We are testing Linux qt4/qt5 and gcc/clang build matrix on Ubuntu 14.04 (Trusty) plus OSX-10.11/Xcode-7.3 and OSX 10.12/Xcode-8.3.
warning: 'handleCommandLine' overrides a member function but is not marked 'override'
unlock() caused a segfault on openSUSE 13.1 / gcc 4.8.1, introduced in fc0de0d. Documentation for std::mutex::unlock says: Unlocks the mutex. The mutex must be locked by the current thread of execution, otherwise, the behavior is undefined. Note, actually I could not see why we need unlock at all. Netherveless we keep that as is. In general I think there are even more issues here: 1. The other processCommand() call is running in locked state. 2. "while( m_running )" could end the loop without going through "if( !m_running )" 3. variables like m_notified and others are used without mutex protection.
It's not enough to protect m_commandQueue. We need to synchronize all other notifying flags as well.
source: https://github.com/ArashPartow/bitmap updated from 1c640637 to 2d2d5bed The old version was writing wrong sizes to the .bmp header (off-by-one).
Got them from Daniel on the Berlin -> Leipzig train ride.
Just a simple test run of the program. So far It does not do something useful on these travis machines. One may look at the build logs for OSX. There are some runtime GL warnings to fix, probably related to the actual problems. The Linux run on travis is much more broken because the GL version there is really really old. Probably we don't want to fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally this patch-set tried to address runtime problems on OSX.
Though it may still not work as it should on OSX we have here at least some maintenance cleanup to make it easier to use and fix this project in future.
We have also added travis-ci scripts to test the build and a very basic run on OSX and Ubuntu 14.04 Trusty. You can already see the first travis logs for this pull-request here.
https://travis-ci.org/NeuroanatomyAndConnectivity/DirectionalityIndicator/builds/240769072
One may look at the travis logs for OSX. There are some runtime GL warnings to fix, probably related to the actual problems.