Skip to content

debug_getRawTransaction: return null instead of error for missing transaction #12151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svlachakis merged 1 commit into from
Jun 26, 2026
Merged

debug_getRawTransaction: return null instead of error for missing transaction #12151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/Nethermind/Nethermind.JsonRpc.Test/Modules/DebugModuleTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,15 @@ public async Task DebugGetRawTransaction_WhenTransactionExists_ReturnsTransactio
Assert.That(serialized, Is.EqualTo($"{{\"jsonrpc\":\"2.0\",\"result\":\"{expected}\",\"id\":67}}"));
}

[Test]
public async Task DebugGetRawTransaction_WhenTransactionNotFound_ReturnsNull()
{
_debugBridge.GetTransactionFromHash(Keccak.Zero).ReturnsNull();

string serialized = await SerializedRequest("debug_getRawTransaction", Keccak.Zero);
Assert.That(serialized, Is.EqualTo("{\"jsonrpc\":\"2.0\",\"result\":null,\"id\":67}"));
}

[Test]
public async Task DebugGetRawReceipts_WhenReceiptsExist_ReturnsHexArray()
{
Expand Down Expand Up @@ -484,10 +493,6 @@ private static IEnumerable<TestCaseData> RawMissingCases()
(Action<IDebugBridge>)(b => b.GetBlock(new BlockParameter(Keccak.Zero)).ReturnsNull()),
"debug_getRawBlock", (object)Keccak.Zero)
{ TestName = "RawBlock_ByHash" };
yield return new TestCaseData(
(Action<IDebugBridge>)(b => b.GetTransactionFromHash(Keccak.Zero).ReturnsNull()),
"debug_getRawTransaction", (object)Keccak.Zero)
{ TestName = "RawTransaction" };
}

private static IEnumerable<TestCaseData> RawBlockAccessListErrorCases()
Expand Down
2 changes: 1 addition & 1 deletion src/Nethermind/Nethermind.JsonRpc/Modules/DebugModule/DebugRpcModule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ public ResultWrapper<ArrayPoolList<byte>> debug_getRawTransaction(Hash256 transa
Transaction? transaction = debugBridge.GetTransactionFromHash(transactionHash);
if (transaction is null)
{
return ResultWrapper<ArrayPoolList<byte>>.Fail($"Transaction {transactionHash} was not found", ErrorCodes.ResourceNotFound);
return ResultWrapper<ArrayPoolList<byte>>.Success(null);
}

RlpBehaviors encodingSettings = RlpBehaviors.SkipTypedWrapping | (transaction.IsInMempoolForm() ? RlpBehaviors.InMempoolForm : RlpBehaviors.None);
Expand Down
Loading