Repository navigation
histogram: ignore negative amounts and support batch updates in PercentileTimer - #1307
Open
reginaldalfret wants to merge 1 commit into
Open
reginaldalfret wants to merge 1 commit into
reginaldalfret wants to merge 1 commit into
Conversation
…centileTimer Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
PercentileTimer, negative durations were unconditionally passed to bucket resolution and incremented the bucket count formin(bucket 0 by default), while the underlyingTimerdropped them according to theTimercontract. This caused the sum of bucket counts to exceedtimer.count()and artificially skewed percentiles toward zero.Additionally,
PercentileTimerdid not overrideTimer.record(long[] amounts, int n, TimeUnit unit), falling back to the default interface loop.This change brings
PercentileTimerin line withPercentileDistributionSummary(see #1303).Root cause
PercentileTimer.record(long, TimeUnit)called:java final long nanos = restrict(unit.toNanos(amount)); timer.record(amount, unit); counterFor(PercentileBuckets.indexOf(nanos)).increment();When
amount < 0,timer.record(amount, unit)dropped the value, butrestrict(negative)clamped the nanos tomin(0ns by default) and incremented bucket 0.Changes
spectator-api/.../PercentileTimer.java:if (amount >= 0).record(long[] amounts, int n, TimeUnit unit)for batch updates, matchingPercentileDistributionSummary.record(long[], int).spectator-api/.../PercentileTimerTest.java:negativeAmountIgnoredtest asserting that negative durations do not incrementcount()or any bucket counters.batchRecordMatchesSingleRecordandbatchRecordMatchesSingleRecordDefaultRangetests verifying that batched updates match single updates across zero, positive, and negative amounts.