Skip to content

add illumos and Solaris build support#293

Merged
rdmark merged 1 commit into
mainfrom
solaris-illumos
Jul 13, 2026
Merged

add illumos and Solaris build support#293
rdmark merged 1 commit into
mainfrom
solaris-illumos

Conversation

@rdmark

@rdmark rdmark commented Jul 12, 2026

Copy link
Copy Markdown
Member

Make the client portable to SunOS-family systems by linking libsocket, exposing platform extensions, detecting the iconv input type, and avoiding assumptions about pthread_t and byte-order macros.

Configure runtime library paths and OmniOS pkgsrc search paths, tighten explicit memory-clearing feature checks, and add CI coverage for OmniOS, OpenIndiana, and Solaris 11 that builds, tests, installs, and smoke-tests afpcmd.

@rdmark
rdmark requested a review from andylemin as a code owner July 12, 2026 06:31
@augmentcode

augmentcode Bot commented Jul 12, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR extends the GitHub Actions CI matrix to cover illumos/Solaris platforms via VM-based jobs.

Changes:

  • Adds new CI jobs for OmniOS, OpenIndiana, and Solaris 11 using vmactions/*-vm runners
  • Introduces a workflow-level SMARTOS_BOOTSTRAP_URL to install a pkgsrc bootstrap (used for the OmniOS build environment)
  • Builds the project with Meson on each platform with -Denable-fuse=false, then runs compile/test/install and a basic afpcmd -h sanity check
  • Uploads Meson logs as artifacts for easier debugging on failures

Motivation: Improves confidence in illumos/Solaris compatibility now that Netatalk consumes these client libraries.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread .github/workflows/ci.yml
@rdmark
rdmark force-pushed the solaris-illumos branch 2 times, most recently from 80b5036 to 819c2aa Compare July 12, 2026 07:53
@rdmark
rdmark force-pushed the solaris-illumos branch from 02849c0 to 1693617 Compare July 12, 2026 10:19
@rdmark rdmark changed the title add CI build jobs for OmniOS, OpenIndiana, Solaris 11 add illumos and Solaris build support Jul 12, 2026
Make the client portable to SunOS-family systems by linking libsocket,
exposing platform extensions, detecting the iconv input type,
and avoiding assumptions about pthread_t and byte-order macros.

Configure runtime library paths and OmniOS pkgsrc search paths,
tighten explicit memory-clearing feature checks, and add CI coverage
for OmniOS, OpenIndiana, and Solaris 11 that builds, tests, installs,
and smoke-tests afpcmd.
@rdmark
rdmark force-pushed the solaris-illumos branch from 1693617 to e112f3d Compare July 12, 2026 10:49
@sonarqubecloud

Copy link
Copy Markdown

@rdmark

rdmark commented Jul 12, 2026

Copy link
Copy Markdown
Member Author

@andylemin FYI this turned into a broad range of illumos/Solaris portability fixes!

@rdmark
rdmark merged commit 362e170 into main Jul 13, 2026
23 checks passed
@rdmark
rdmark deleted the solaris-illumos branch July 13, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants