Some interp stuff #1657
Draft
Some interp stuff #1657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agiel
added
the
Tournament Priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can see in the SDK code
FIXME_INTERP_RATIO, I believe this is because thecl_interpvalue is being used instead ofcl_interp_ratioif it's larger and I don't really believe that's how it should work, probably ideally want clients to have the lowest interp they asked for between the two.This doesn't change all that behaviour, it's a very quick fix that just changes the default
cl_interpto match a resulting value when default ratio of 2 is used assumingcl_updaterate 66(clamped by server). Also we don't allow clients to further increase their interp beyond 0.1s, as it's not necessary and causes greater problems in lag comp, not to mention typos and bad configs reducing the quality of the gameplay experience.Unfortunately defaults for cl_cmdrate and cl_updaterate live in the engine so can't be changed at the moment, but these can be enforced by server settings which most server operators already do.
Ideally the clients would get the minimum interp they have asked for or the minimum server enforced interp if there is one.