Skip to content

Conversation

@sunzenshen
Copy link
Contributor

@sunzenshen sunzenshen commented Feb 2, 2026

Description

Prevent dereferencing NULL m_pWorldRenderList

Toolchain

  • Windows MSVC VS2022

Linked Issues

@Rainyan
Copy link
Collaborator

Rainyan commented Feb 2, 2026

Do we know what the context is in which m_pWorldRenderList might be null here, and do we know if it's a recent regression of our own of just some SDK jank? Or is this a defensive check just in case?

@sunzenshen
Copy link
Contributor Author

Do we know what the context is in which m_pWorldRenderList might be null here, and do we know if it's a recent regression of our own of just some SDK jank? Or is this a defensive check just in case?

Pardon the delay in response, was writing up this Issue:
#1642

Naturally I welcome a more in depth analysis of the root cause, but this patch seems to allow me to record an entire match without encountering the crash.

@Rainyan Rainyan requested review from a team and Rainyan February 3, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash in CRendering3dView::DrawWorld

2 participants