JGR mode behavior dispatcher for bots

[sunzenshen]

Description

Encapsulates bot behaviors related to the JGR game mode such that modifications to the behavior of Juggernaut mode bots can be isolated away from general seek and destroy behavior.

Toolchain

• Windows MSVC VS2022

[sunzenshen]

Demo footage: https://streamable.com/fb68kk

[DESTROYGIRL]

Got an assert here after a round had ended. Probably not a fault of changes in this PR but ???
Could be that m_bJuggernautItemExists is not set correctly after a round ends

	server.dll!assert_cast<CNEO_Juggernaut *,CBaseEntity>(CBaseEntity * pSource) Line 576	C++
 	server.dll!CNEORules::JuggernautItemExists() Line 4354	C++
 	server.dll!CNEOBotJgrSeek::RecomputeSeekPath(CNEOBot * me) Line 87	C++
 	server.dll!CNEOBotSeekAndDestroy::OnResume(CNEOBot * me, Action<CNEOBot> * interruptingAction) Line 201	C++
 	server.dll!Action<CNEOBot>::InvokeOnResume(CNEOBot * me, Behavior<CNEOBot> * behavior, Action<CNEOBot> * interruptingAction) Line 1529	C++
 	server.dll!Action<CNEOBot>::ApplyResult(CNEOBot * me, Behavior<CNEOBot> * behavior, ActionResult<CNEOBot> result) Line 1697	C++
 	server.dll!Action<CNEOBot>::InvokeUpdate(CNEOBot * me, Behavior<CNEOBot> * behavior, float interval) Line 1379	C++
 	server.dll!Action<CNEOBot>::InvokeUpdate(CNEOBot * me, Behavior<CNEOBot> * behavior, float interval) Line 1379	C++
 	server.dll!Action<CNEOBot>::InvokeUpdate(CNEOBot * me, Behavior<CNEOBot> * behavior, float interval) Line 1379	C++
 	server.dll!Behavior<CNEOBot>::Update(CNEOBot * me, float interval) Line 258	C++
 	server.dll!CNEOBotIntention::Update() Line 2664	C++
 	server.dll!INextBot::Update() Line 133	C++
 	server.dll!NextBotPlayer<CNEO_Player>::Update() Line 976	C++
 	server.dll!CNEOBot::Update() Line 837	C++
 	server.dll!NextBotPlayer<CNEO_Player>::PhysicsSimulate() Line 743	C++
 	server.dll!CNEOBot::PhysicsSimulate() Line 693	C++
 	server.dll!Physics_SimulateEntity(CBaseEntity * pEntity) Line 2019	C++
 	server.dll!Physics_RunThinkFunctions(bool simulating) Line 2075	C++
 	server.dll!CServerGameDLL::GameFrame(bool simulating) Line 1281	C++

[Rainyan]

Got an assert here after a round had ended. Probably not a fault of changes in this PR but ??? Could be that m_bJuggernautItemExists is not set correctly after a round ends

	server.dll!assert_cast<CNEO_Juggernaut *,CBaseEntity>(CBaseEntity * pSource) Line 576	C++
 	server.dll!CNEORules::JuggernautItemExists() Line 4354	C++
 	server.dll!CNEOBotJgrSeek::RecomputeSeekPath(CNEOBot * me) Line 87	C++
 	server.dll!CNEOBotSeekAndDestroy::OnResume(CNEOBot * me, Action<CNEOBot> * interruptingAction) Line 201	C++
 	server.dll!Action<CNEOBot>::InvokeOnResume(CNEOBot * me, Behavior<CNEOBot> * behavior, Action<CNEOBot> * interruptingAction) Line 1529	C++
 	server.dll!Action<CNEOBot>::ApplyResult(CNEOBot * me, Behavior<CNEOBot> * behavior, ActionResult<CNEOBot> result) Line 1697	C++
 	server.dll!Action<CNEOBot>::InvokeUpdate(CNEOBot * me, Behavior<CNEOBot> * behavior, float interval) Line 1379	C++
 	server.dll!Action<CNEOBot>::InvokeUpdate(CNEOBot * me, Behavior<CNEOBot> * behavior, float interval) Line 1379	C++
 	server.dll!Action<CNEOBot>::InvokeUpdate(CNEOBot * me, Behavior<CNEOBot> * behavior, float interval) Line 1379	C++
 	server.dll!Behavior<CNEOBot>::Update(CNEOBot * me, float interval) Line 258	C++
 	server.dll!CNEOBotIntention::Update() Line 2664	C++
 	server.dll!INextBot::Update() Line 133	C++
 	server.dll!NextBotPlayer<CNEO_Player>::Update() Line 976	C++
 	server.dll!CNEOBot::Update() Line 837	C++
 	server.dll!NextBotPlayer<CNEO_Player>::PhysicsSimulate() Line 743	C++
 	server.dll!CNEOBot::PhysicsSimulate() Line 693	C++
 	server.dll!Physics_SimulateEntity(CBaseEntity * pEntity) Line 2019	C++
 	server.dll!Physics_RunThinkFunctions(bool simulating) Line 2075	C++
 	server.dll!CServerGameDLL::GameFrame(bool simulating) Line 1281	C++

assert_cast fails the assertion if both are true:

• the input pointer value is not nullptr
• dynamic_cast of the input pointer results in nullptr

i.e. the pointer does exist, but is not convertible to the desired type.

Because m_hJuggernaut is declared as CNetworkHandle( CBaseEntity, m_hJuggernaut );, it can accept a pointer to any class that derives from CBaseEntity. So I'd guess it was holding a CNEO_Player* at the time of the assertion failure rather than a CNEO_Juggernaut* (possibly from here?)

Whether m_hJuggernaut should be this way I suppose is more nuanced.

[DESTROYGIRL]

assert_cast fails the assertion if both are true:

* the input pointer value is not `nullptr`

* `dynamic_cast` of the input pointer results in `nullptr`

i.e. the pointer does exist, but is not convertible to the desired type.

Because m_hJuggernaut is declared as CNetworkHandle( CBaseEntity, m_hJuggernaut );, it can accept a pointer to any class that derives from CBaseEntity. So I'd guess it was holding a CNEO_Player* at the time of the assertion failure rather than a CNEO_Juggernaut* (possibly from here?)

Whether m_hJuggernaut should be this way I suppose is more nuanced.

Yea, I put the assert_cast there to ensure that m_hJuggernaut is a CNEO_Juggernaut and not a player when m_bJuggernautItemExists is true. m_hJuggernaut switching between player & item is intentional

[sunzenshen]

Do we want to consider revisiting that assert in this PR or as a separate issue? It might be easier to replicate the issue separately, using the bots to passively set up the test conditions.

[DESTROYGIRL]

Good work, this is a nice foundation and makes testing way easier. Speaking of which. It's assert city in here
I'll revist some of this once I've got these fixed up, as they have been made quite obvious... lol