fix loading ui crash getting an non valid adress for UText#1174
fix loading ui crash getting an non valid adress for UText#1174Nbc66 wants to merge 1 commit intoNeotokyoRebuild:masterfrom
Conversation
| { | ||
| NeoUI::Label(L"Press ESC to cancel"); | ||
| if (m_pLabelInfo) NeoUI::Label(m_pLabelInfo->GetTextImage()->GetUText()); | ||
| if (m_pLabelInfo) //NeoUI::Label(m_pLabelInfo->GetTextImage()->GetUText()); |
There was a problem hiding this comment.
But this will cause it to if over the next line and no one else seem to have this issue so I wouldnt completely cut it out? You altered the loading dialog UI/res file, localization difference, or something? At most can just expand the if statement to check more pointers.
There was a problem hiding this comment.
the thing i would recomend is just get the uText at the beginning when you cast it to a label there is no other way of doing this also I haven't touched a single resfile for this. this only happens cause the pointer becomes invalid after moving out of the scope when casting the pointer and the pointer becoming corupted
There was a problem hiding this comment.
I'm not too sure if the text gets properly updated on each onmessage activate. You could also try to nullptr out the panel pointers on deactivate and just before refetching panels to see if it helps somewhat
|
so it's a problem with the source sdk 2013 mp version, close? |
|
Superseded by #1183 |
3 participants
Description
There is a crash that happens in the neo_loading UI which is caused by m_bInfoLabel being an invalid memory address
This fixes it by just removing the info label step
Toolchain
Linked Issues