Replace ring_to_mat dictionary by example_rings vector#2076
Open
fingolfin wants to merge 2 commits into
Open
Conversation
lgoettgens
approved these changes
May 12, 2025
lgoettgens
reviewed
May 12, 2025
9ab6c77 to
7003d92
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2076 +/- ##
==========================================
- Coverage 88.18% 88.17% -0.01%
==========================================
Files 100 100
Lines 36841 36840 -1
==========================================
- Hits 32488 32485 -3
- Misses 4353 4355 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1902 -- I'd still like to get rid of the
example_ringsbut at least the new code is closer to what I'd expect a successor in the conformance test suite to look like...