Add basic functionality for univariate Ore operators#2411
Draft
ooinaruhugh wants to merge 6 commits into
Draft
Conversation
Author
|
As long as this is a draft, I am ignoring some style rules. I didn't sort the |
lgoettgens
reviewed
May 20, 2026
Comment on lines
+1625
to
+1627
| function PolyFracFieldAnyMap{D,C,V}(d::D,ϕ::V) where {D,C,V} | ||
| return new{D,C,V}(d,ϕ) | ||
| end |
Member
There was a problem hiding this comment.
Suggested change
| function PolyFracFieldAnyMap{D,C,V}(d::D,ϕ::V) where {D,C,V} | |
| return new{D,C,V}(d,ϕ) | |
| end | |
| function PolyFracFieldAnyMap{D,C,V}(d::D,phi::V) where {D,C,V} | |
| return new{D,C,V}(d,phi) | |
| end |
please do not use unicode in variable names, see https://docs.oscar-system.org/dev/DeveloperDocumentation/styleguide/#Unicode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds basic functionality for univariate Ore polynomials. This is implemented in pure Julia.
For now, this contains arithmetic capabilities and implements an interface similar or equal to
NCPolyRingand such.There are some minor additions that are technically required that would come with this PR.
Currently, there is no way to define a ring homomorphism of fraction fields (or function fields for that instance).
They are a rather common choice for coefficient fields of Ore algebras, that's why they are of interest.
Since for fraction fields of polynomial rings, the notion would naturally extend, I also introduce a type
PolyFracFieldAnyMapthat mimicsPolyRingAnyMap.I would keep this PR at this scope since this is also the point where we fix the interface for Ore algebras
which will be relevant as soon we make use of the implementation in FLINT for some specialised cases.