Skip to content

Add basic functionality for univariate Ore operators#2411

Draft
ooinaruhugh wants to merge 6 commits into
Nemocas:masterfrom
ooinaruhugh:kafe/ore-poly
Draft

Add basic functionality for univariate Ore operators#2411
ooinaruhugh wants to merge 6 commits into
Nemocas:masterfrom
ooinaruhugh:kafe/ore-poly

Conversation

@ooinaruhugh
Copy link
Copy Markdown

This pull request adds basic functionality for univariate Ore polynomials. This is implemented in pure Julia.
For now, this contains arithmetic capabilities and implements an interface similar or equal to NCPolyRing and such.

There are some minor additions that are technically required that would come with this PR.
Currently, there is no way to define a ring homomorphism of fraction fields (or function fields for that instance).
They are a rather common choice for coefficient fields of Ore algebras, that's why they are of interest.
Since for fraction fields of polynomial rings, the notion would naturally extend, I also introduce a type PolyFracFieldAnyMap that mimics PolyRingAnyMap.

I would keep this PR at this scope since this is also the point where we fix the interface for Ore algebras
which will be relevant as soon we make use of the implementation in FLINT for some specialised cases.

@ooinaruhugh
Copy link
Copy Markdown
Author

As long as this is a draft, I am ignoring some style rules. I didn't sort the exports.jl so I don't lose track of what I've added

Comment thread src/generic/GenericTypes.jl Outdated
Comment on lines +1625 to +1627
function PolyFracFieldAnyMap{D,C,V}(d::D,ϕ::V) where {D,C,V}
return new{D,C,V}(d,ϕ)
end
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function PolyFracFieldAnyMap{D,C,V}(d::D,ϕ::V) where {D,C,V}
return new{D,C,V}(d,ϕ)
end
function PolyFracFieldAnyMap{D,C,V}(d::D,phi::V) where {D,C,V}
return new{D,C,V}(d,phi)
end

please do not use unicode in variable names, see https://docs.oscar-system.org/dev/DeveloperDocumentation/styleguide/#Unicode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants