Add Puiseux polynomials#2391
Draft
ollieclarke8787 wants to merge 7 commits into
Draft
Conversation
joschmitt
added
enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2391 +/- ##
==========================================
- Coverage 88.12% 87.59% -0.53%
==========================================
Files 128 129 +1
Lines 32886 33084 +198
==========================================
Hits 28981 28981
- Misses 3905 4103 +198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
The test file needs to be included explicitly to be executed (there is no magic like in OSCAR). I assume it could fit in the list of |
lgoettgens
reviewed
Apr 10, 2026
| K, (t1,t2,t3) = laurent_polynomial_ring(QQ, ["t1","t2","t3"]) | ||
| K_p,(tp1,tp2,tp3) = puiseux_polynomial_ring(QQ, ["t1","t2","t3"]) | ||
| @test K_p.baseRing == K | ||
| @test K_p == Oscar.PuiseuxMPolyRing(K) |
Member
There was a problem hiding this comment.
this file contains multiple references to Oscar which won't work here
Contributor
|
@lgoettgens Good point, I suggest we remove these for now and once this PR is merged and a new release of AA has happened, I will open a PR in OSCAR. |
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Removed trivial tests from the PuiseuxPolynomials test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working repository for adding Puiseux Polynomials to AA, this should supersede oscar-system/Oscar.jl#5861