Fixes rejuvenate not preserving skin color#5301
Closed
l3lb0t wants to merge 1 commit intoNebulaSS13:devfrom
Closed
Fixes rejuvenate not preserving skin color#5301l3lb0t wants to merge 1 commit intoNebulaSS13:devfrom
l3lb0t wants to merge 1 commit intoNebulaSS13:devfrom
Conversation
| var/list/organ_data = has_limbs[limb_type] | ||
| var/limb_path = organ_data["path"] | ||
| var/obj/item/organ/external/E = new limb_path(H, null, supplied_data) //explicitly specify the dna and bodytype | ||
| E.skin_colour = supplied_data.skin_color //match skin colors |
Contributor
There was a problem hiding this comment.
This should probably be done in this proc:
/obj/item/organ/external/copy_from_mob_snapshot(var/datum/mob_snapshot/supplied_appearance)
Also should probably go to stable as it's a fix.
MistakeNot4892
added
the
needs rebase/retarget
Author
|
Moved to #5304 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I noticed in testing that if you chop your arm off, and regrow it with the Rejuvenate verb (something I often find myself doing), the arm you grow back is inexplicably white, regardless of your character's actual skin color.
Why and what will this PR improve
Now, if you regrow a limb, it will actually match your body, rather than looking like you stole someone else's arm. This is probably a good thing.
Authorship
The one, the only, Karl Johansson
Changelog
🆑 Karl Johansson
bugfix: Regrown limbs now match the skin color of the rest of your body
/:cl: