Overhaul a lot of visible_message messages to use grammar helpers#5206
Draft
out-of-phaze wants to merge 6 commits intoNebulaSS13:devfrom
Draft
Overhaul a lot of visible_message messages to use grammar helpers#5206out-of-phaze wants to merge 6 commits intoNebulaSS13:devfrom
out-of-phaze wants to merge 6 commits intoNebulaSS13:devfrom
Conversation
out-of-phaze
added
has dependencies
out-of-phaze
force-pushed
the
experiment/grammar-overhaul
branch
7 times, most recently
from
66a1f9c to
0ca500d
Compare
out-of-phaze
force-pushed
the
experiment/grammar-overhaul
branch
from
7a13988 to
71133e9
Compare
out-of-phaze
force-pushed
the
experiment/grammar-overhaul
branch
from
71133e9 to
6e04f47
Compare
out-of-phaze
removed
the
has dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #5205. Uses the grammar helpers introduced in that PR. Extensive changes, some handling is a little clunky and needs to be redone. Has not been tested yet.
Also, as a note to myself for later: Bedroll and possibly bed visible_messages are broken because a self_message is passed despite it being called on an
/obj.