feat(seccomp): allow nested user namespaces for application sandboxes - #55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seccomp filter introduced in #53 blocks the namespace operations used by Chromium and Electron to create their internal process sandbox. As a result, the existing Brave, Slack, and Discord examples fail with either an invalid SUID sandbox helper or
No usable sandbox.This adds an opt-in option
fhsenv.opts.allowNestedUserNamespacesto disable the seccomp filter. Right now this option only permits the operations needed by Chromium's user-namespace sandbox. Otherunshareflags remain blocked.Most importantly, the rules added for CVE-2017-5226 and CVE-2023-28100 remain active. This therefore does not make the seccomp filter optional or revert the protection introduced in #53.