Rename module to snake_case - #79
Open
irgolic wants to merge 3 commits into
Open
Conversation
irgolic
force-pushed
the
rename-module-to-underscore-case
branch
from
August 25, 2026 23:54
85d8d6f to
01904b5
Compare
irgolic
force-pushed
the
rename-module-to-underscore-case
branch
from
August 25, 2026 23:57
01904b5 to
ea695e5
Compare
PeterWaIIace
requested changes
Aug 26, 2026
PeterWaIIace
left a comment
PeterWaIIace
left a comment
Collaborator
There was a problem hiding this comment.
Let''s make it eyegestures instead of eye_gestures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regardless of what the PyPi package is called (
EyeGestures, camelCase), the python convention is for modules to he written in underscore_case.This PR renamespaces the module from
eyeGesturestoeye_gestures, and adds a graceful deprecation import fallback, so it shouldn't break anything for current users – it will however emit a DeprecationWarning. You don't need to remove theeyeGesturesimport redirect for at least a few years (if ever, if the extra filename doesn't bother you).I've also added a unit test for this deprecation.