Repository navigation
Conversation
On Android the box laid over the field to catch its tap would swallow the X too, so the field opens its dialog from its own interaction source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A compact
native:date-pickergets aclearableattribute: while it holds a value, an X sits inside the field (beside the calendar icon on Android, beside the date button on iOS), and tapping it sends''through@change/native:model— the empty value the wire already uses for "nothing chosen" — without opening the dialog;clear-labelnames the X for screen readers. On Android the transparent box laid over the field to catch its tap would have swallowed the X as well, so the field now opens the dialog from its own interaction source and its accessibility click, and never takes focus, which keeps its resting look. Checked on an Android 14 device and with a new Robolectric test intests/android, since CI does not build Kotlin. I have no iOS device, so the Swift side follows the existing renderer and is covered only by a source-text test — could someone check it on iOS?