Repository navigation
Even out the commit action row, full-width hairlines, fixed logo size - #80
shanerbaner82 wants to merge 3 commits into
Conversation
…the logo size The star, pastel, Quote and Reply actions now share the row equally, X-style, with Reply as an icon like the rest. The hairline under a commit takes the rail's gutter as padding, and under a thread it's the last reply's own border, so both run the row's full width. The nav bar logo gets an explicit 105x28 size, as it pulsed in and out on device without one. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…n it Share was the first item of More. It's now a button of its own at the end of the row, like X's, and More keeps Pin, Report and Delete, and isn't drawn when there are none, such as on someone else's commit that isn't approved yet. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Love it, but there's a problem with the Reply buttons |
RaphaelFakhri
left a comment
RaphaelFakhri
left a comment
There was a problem hiding this comment.
The wrapped "› 1 reply" in the screenshot above comes from the replies link getting flex-1 like the icon buttons. In a rendered row with stars and one reply, star, quote, reply-to, replies and share all have flex_grow: 1, but replies has no min_width and its text has no max_lines, so it gets an equal share of the row and its label wraps into that width. On a phone-width row that share leaves little room for the label once you take off the padding and chevron. Dropping flex-1 from the replies link (it is text, so let it size to its content) and adding :max-lines="1" to its label keeps the icon cells even without squeezing it.
The second commit also moves Share out of More into the row and hides More when the menu is empty, which the description doesn't mention yet. The branch conflicts with main in commit-row-content.blade.php: when you resolve it, keep the staged-commit opacity-[0.6] from #86 alongside the pl-[64] change. CONTRIBUTING.md asks for before and after screenshots on iOS and Android in light and dark mode for these rows.
resources/views/native/partials/commit-actions.blade.php line 107: Adding :max-lines="1" keeps "1 reply" on one line if the row does get tight.
|
|
||
| @if ($showsReplies) | ||
| <native:pressable ref="replies-{{ $commit->id }}" @press="{{ $repliesPress }}" class="flex-row h-[36] px-2 gap-1 items-center" a11y-label="{{ $isOpen ? 'Hide replies' : \App\Devnull\Display::count($repliesCount, 'reply', 'replies') }}"> | ||
| <native:pressable ref="replies-{{ $commit->id }}" @press="{{ $repliesPress }}" class="flex-row flex-1 h-[36] px-2 gap-1 items-center" a11y-label="{{ $isOpen ? 'Hide replies' : \App\Devnull\Display::count($repliesCount, 'reply', 'replies') }}"> |
There was a problem hiding this comment.
flex-1 here gives the "N replies" label the same width as an icon cell. Consider leaving it off this link so the label sizes to its content.
What
Verified
Pest passes (1188 tests, arch test excluded: it runs out of PHP's default memory). Checked on an iPhone 15 Pro Max from a screen recording; the action row and hairline changes looked right, and the logo fix was confirmed there too.
Not in this PR
App Store Connect lists the in-flight version as 1.0 with bundle ID
com.nativephp.devnull. Those are set on the Bifrost side, not in the repo.🤖 Generated with Claude Code