Bringing feature/splits-interface branch current - adding in unit test fixes#3491
Draft
avgAGB wants to merge 31 commits intointegrationfrom
Draft
Bringing feature/splits-interface branch current - adding in unit test fixes#3491avgAGB wants to merge 31 commits intointegrationfrom
avgAGB wants to merge 31 commits intointegrationfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been an ongoing effort to cache the calls to the SplitsCache in order to improve memory usage and processing time during ingest. Dylan and Dylan have already done the legwork involved in replacing SplitsFile pulls with the cache references, but this ticket was to shore up some compatibility issues with recent unit tests and to rebase it against a more current integration branch.