Added units to report#176
Conversation
Added sequencing units for flowcells "Universal-XX" instead of lanes.
| Ordered sequencing units | ||
| : {{ project.num_lanes }} unit{% if project.num_lanes > 1 %}s{% endif %} | ||
| {% elif "illumina" in project.sequencer_manufacturer or "element" in project.sequencer_manufacturer -%} | ||
| Ordered lanes | ||
| : {{ project.num_lanes }} lane{% if project.num_lanes > 1 %}s{% endif %} |
There was a problem hiding this comment.
Do we keep Ordered Lanes too for Illumina? They seem to have the same value.
There was a problem hiding this comment.
@aanil Its inside the 'elif' though so it would be the cases where it's not using universal units right?
There was a problem hiding this comment.
Exactly, either it's illumina and uses sequencing units, or illumina/element and uses lanes as before
There was a problem hiding this comment.
I guess we could condense the first condition down to
{% if project.unit_type -%}
since it'll always be set if we are using sequencing units.
There was a problem hiding this comment.
I'd rather check for the specific value of unit_type then:
if project.unit_type == "Sequencing units" or
if project.unit_type != ""
Just to make it a bit more explicit.
There was a problem hiding this comment.
Sure! Then we need to account for ONT too somehow.
Added unit_type flowcell for ONT data
alneberg
left a comment
alneberg
left a comment
There was a problem hiding this comment.
I think this looks good now!
almahans
merged commit ef72df3
into
NationalGenomicsInfrastructure:master
3 participants
Added sequencing units for flowcells "Universal-XX" instead of lanes.