ICRC-2 & ICRC-3: Approve and Transfer From & Get Transactions#18
Open
receronp wants to merge 13 commits intoNatLabs:mainfrom
Open
ICRC-2 & ICRC-3: Approve and Transfer From & Get Transactions#18receronp wants to merge 13 commits intoNatLabs:mainfrom
receronp wants to merge 13 commits intoNatLabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ICRC-2 and ICRC-3 Standards for Approve and Transfer From methods (icrc2_approve, icrc2_transfer_from, icrc2_allowance) as specified in the DFINITY ICRC-2 Standard Methods and Get Transactions method (icrc3_get_transactions) as specified in DFINITY ICRC-3 Standard Methods. Methods from ICRC-1 are supported by reusing code from the ICRC-1 codebase, with icrc1_supported_standards modified to report in addition the ICRC-2 and ICRC-3 standards.
Actor tests for the new standard methods have also been created, covering ApproveError and TransferFromError cases, as well as the examples defined in the DFINITY ICRC-2 Standard Examples.