Fix SAMsimPVWattsCommercialExample for PySAM 8 - #231
Merged
brtietz merged 1 commit intoSep 27, 2026
Merged
Conversation
brtietz
approved these changes
Sep 27, 2026
brtietz
left a comment
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks for fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #225.
With
nlr-pysam8.0.0, Cashloan requiresdepr_custom_schedule, which100kW_PVWatts.jsondid not have, so the example failed with "depr_custom_schedule not assigned". I added"depr_custom_schedule": [0]to the JSON, the value the PVWattsCommercial Cashloan default uses.The other new detailed depreciation inputs are optional, so this is the only one needed. The NPV is the same as before on both 8.0.0 and 7.1.1 (253909.04), so the change does not alter the example's results.