Fix ResidentialPVBatteryWithCustomDispatch example for PySAM 8 - #230
Merged
brtietz merged 1 commit intoSep 27, 2026
Merged
Conversation
brtietz
approved these changes
Sep 27, 2026
brtietz
left a comment
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
New example code works well, thank you!
I expect the test failures are unrelated, so I'll merge this and debug those elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #224.
PySAM 8 added
use_snow_weather_fileto Pvsamv1, and none of the Pvsamv1 defaults innlr-pysam8.0.0 set it, so the example failed inexecute()with "required but not assigned". The example now setsLosses.use_snow_weather_file = 0. The snow loss model is off in this config (en_snow_model = 0), so the value does not affect the results.Tested with
nlr-pysam8.0.0: the script runs and the roundtrip efficiency matches the 7.1 run (91.24%).