Repository navigation
Add CONFIG_SCHEMA, drop the bleak requirement and the removed UP038 rule - #28
Merged
Merged
Conversation
hassfest requires a CONFIG_SCHEMA on integrations that define async_setup. The integration is set up through config entries only, so use config_entry_only_config_schema. bleak is pinned by Home Assistant and provided by the bluetooth integration this one already depends on. Requiring bleak>=0.21.1 only risks a conflict with that pin. ruff removed UP038, so ignoring it only produced a warning on every run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Housekeeping with no behaviour change. Merge this before the other open PRs; it merges cleanly with each of them.
CONFIG_SCHEMA: Home Assistant expects it on integrations that defineasync_setup(hassfest'sconfig_schemacheck; it did not fail CI without it so far). The integration is set up through config entries only, so it usescv.config_entry_only_config_schema(DOMAIN).bleak>=0.21.1frommanifest.json: Home Assistant pins bleak and provides it through thebluetoothintegration this one already depends on. Our own requirement can only conflict with that pin.UP038from the ruff ignore list: current ruff removed the rule, so ignoring it only printed a warning on every run. The pre-commit hook still pins ruffv0.12.1, whereUP038is deprecated and not selected;ruff@0.12.1 checkpasses on this branch, and--select UP038finds nothing either.Not in this PR
fix/stuck-gatt-recoveryrewritesrequirements.test.txtto pinhomeassistantandpytest-homeassistant-custom-componentto matching versions, which fixes pip silently installing an older plugin release. Changing the file here too would only conflict.bleak>=0.21.1.fix/stuck-gatt-recoveryrewrites that block.Test plan
pytest testson WSL (HA 2025.6): 347 passed, 68 snapshots passed. This needs the Bluetooth mgmt-socket fixture fromfix/stuck-gatt-recovery'sconftest.py, applied for the run only. Without it,mainand this branch fail the same 17 tests on WSL.ruff check: clean, and no more UP038 warning🤖 Generated with Claude Code