Merged
Conversation
| return new ErrorResponse(e.getMessage(), HttpStatus.BAD_REQUEST); | ||
| } | ||
|
|
||
| @ExceptionHandler |
There was a problem hiding this comment.
А зря убрала обработку Exception, это очень правильно все оставшиеся эксепшены обработать в статус INTERNAL_SERVER_ERROR
| @Data | ||
| @Entity | ||
| @EqualsAndHashCode(of = {"userId"}) | ||
| public class Friends { |
There was a problem hiding this comment.
Классы-сущности для таблиц-связок делать избыточно. Ты же захочешь получать из БД уже готовые сущности или их коллекции.
There was a problem hiding this comment.
InMemory реализации нам уже не понадобятся, лучше удалить из проекта
VadimZharkov
suggested changes
Apr 28, 2025
VadimZharkov
left a comment
VadimZharkov
left a comment
There was a problem hiding this comment.
Доработки увидел, все ок. Еще пару моментов нужно исправить.
VadimZharkov
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.