Stop a metadata step from taking down a finished release - #67
Merged
tonytonycoder11 merged 1 commit intoJul 31, 2026
Merged
Conversation
The v2.0.0 tag published every jar to Maven Central and attested all eight, and then the job went red. The linked-artifacts step got a 404, "no artifacts found", for a digest that does have an attestation — and because the step is fatal and runs before the release object is created, a release that had already succeeded ended with no GitHub Release and a failed run. The metadata is worth having. It is not worth that. The step is continue-on-error now, each record failure is a warning rather than an exit, and the run's log still names what was not written. The GitHub Release moves ahead of it, so the user-visible half of a release can never again be lost to the optional half. Two things the failure taught, both written where the next person will look. The endpoint is checked before writing, because it has no DELETE and a duplicate cannot be cleaned up. And GH_TOKEN falls back from an ARTIFACT_METADATA_TOKEN secret to GITHUB_TOKEN: whether the default token may write to this org-level endpoint is undocumented, the published docs state only artifact-metadata:read, and this tag is the first that tried. The 404 itself is not diagnosed here. It may be permission, it may be that a record needs an artifact the org already knows about rather than one it can reach through an attestation. Either way the release should not have failed while we find out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
v2.0.0tag published every jar to Maven Central and attested all eight, and then the job went red.The linked-artifacts step got
404 no artifacts foundfor a digest that does have an attestation(
gh api repos/NaCode-Studios/Kdrant/attestations/sha256:18ad27e2…returns one). Because that step isfatal and runs before the release object is created, a release that had already succeeded finished
with a red run and no GitHub Release. I created the release by hand from the changelog — the same
awkextraction the workflow does, so the body is derived and not composed.
What changes
continue-on-error, each record failure is a warning instead of an exit, and the logstill names what was not written. Supply-chain metadata is worth having; it is not worth undoing a
successful publish.
lost to the optional half.
GH_TOKENfalls back from anARTIFACT_METADATA_TOKENsecret toGITHUB_TOKEN. Whether the defaulttoken may write to this org-level endpoint is undocumented — the published docs state only
artifact-metadata:readfor reads — and this tag is the first that tried it.What this does not do. It does not diagnose the 404. It may be permission, or a record may need an
artifact the org already knows about rather than one reachable through an attestation. That is worth
finding out, and the release should not have failed while we do.
2.0.0itself is fine: published, attested, tagged, and the Release exists.