Point code ownership at the libraries team instead of one account - #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/CODEOWNERSnamed a single account, so every pull request opened fromthat same account waited on a review only its author could give. The protection
rule was doing exactly what it was told; there was simply nobody else to ask.
Ownership now sits on
@NaCode-Studios/libraries, the team that already holdswrite access to this repository. Nothing changes while the team has one member.
The moment a second person joins, GitHub starts requesting review from them and
the deadlock resolves without anyone editing this file again.