Update CUTLASS and align build flags with newer headers#535
Merged
Tom94 merged 1 commit intoApr 1, 2026
Conversation
Contributor
|
Much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_slice3x3cuteheaders build cleanlyWhy
Issue #530 points out that the current bundled CUTLASS revision fails to compile because of the
set_slice3x3typo inmatrix.h. The direct bump in PR #531 moves too far forward and trips the build because newer CUTLASS requires a newer language mode and a conforming MSVC preprocessor.This change takes the smaller upstream CUTLASS fix commit and makes the project build settings match what that dependency now expects.
Validation
cmake -S . -B build-cutlass-check -G Ninja -DTCNN_BUILD_TESTS=1cmake --build build-cutlass-check --target test_gridtest_grid.exectest --output-on-failure -V -R test_gridFixes #530.