Fix metadata-only setup commands for PyTorch bindings#534
Open
ayushozha wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup.pycommands such asegg_infopkg_resourcesversion parsing import withpackaging.version.parseTCNN_CUDA_ARCHITECTURESfor headless or CPU-only PyTorch install environmentsWhy
Issue #503 fails during metadata generation before the extension build even starts. That prevents
pipfrom reaching the point where users can provideTCNN_CUDA_ARCHITECTURESexplicitly on shared or headless systems.This change keeps metadata-only commands lightweight, preserves the existing build-time requirement for a known compute capability, and updates the setup script to work in a current setuptools environment where
pkg_resourcesis no longer available.Validation
python -m py_compile bindings/torch/setup.pypython setup.py egg_infopython setup.py --namepython setup.py build_extnow fails fast with a clearTCNN_CUDA_ARCHITECTURESmessage instead of failing during metadata generationCloses #503.